lkml.org 
[lkml]   [2020]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] pwm: mediatek: add longer period support
From
Date


On 03/03/2020 11:19, Sam Shih wrote:
> The pwm clock source could be divided by 1625 with PWM_CON
> BIT(3) setting in mediatek hardware.
>
> This patch add support for longer pwm period configuration,
> which allowing blinking LEDs via pwm interface.

Is this a fix? In this case please provide a Fixes tag with the commit ID which
introduced the bug.

Thanks
Matthias

>
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> ---
> drivers/pwm/pwm-mediatek.c | 34 ++++++++++++++++++++++++++++++----
> 1 file changed, 30 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index b94e0d09c300..c64ecff6c550 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -121,8 +121,11 @@ static int pwm_mediatek_config(struct pwm_chip *chip, struct pwm_device *pwm,
> int duty_ns, int period_ns)
> {
> struct pwm_mediatek_chip *pc = to_pwm_mediatek_chip(chip);
> - u32 clkdiv = 0, cnt_period, cnt_duty, reg_width = PWMDWIDTH,
> - reg_thres = PWMTHRES;
> + /* The source clock is divided by 2^clkdiv or iff the clksel bit
> + * is set by (2^clkdiv*1625)
> + */
> + u32 clkdiv = 0, clksel = 0, cnt_period, cnt_duty,
> + reg_width = PWMDWIDTH, reg_thres = PWMTHRES;
> u64 resolution;
> int ret;
>
> @@ -133,12 +136,30 @@ static int pwm_mediatek_config(struct pwm_chip *chip, struct pwm_device *pwm,
>
> /* Using resolution in picosecond gets accuracy higher */
> resolution = (u64)NSEC_PER_SEC * 1000;
> + /* Calculate resolution based on current clock frequency */
> do_div(resolution, clk_get_rate(pc->clk_pwms[pwm->hwpwm]));
> -
> + /* Using resolution to calculate cnt_period which represents
> + * the effective range of the PWM period counter
> + */
> cnt_period = DIV_ROUND_CLOSEST_ULL((u64)period_ns * 1000, resolution);
> while (cnt_period > 8191) {
> + /* Using clkdiv to reduce clock frequency and calculate
> + * new resolution based on new clock speed
> + */
> resolution *= 2;
> clkdiv++;
> + if (clkdiv > PWM_CLK_DIV_MAX && !clksel) {
> + /* Using clksel to divide the pwm source clock by
> + * an additional 1625, and recalculate new clkdiv
> + * and resolution
> + */
> + clksel = 1;
> + clkdiv = 0;
> + resolution = (u64)NSEC_PER_SEC * 1000 * 1625;
> + do_div(resolution,
> + clk_get_rate(pc->clk_pwms[pwm->hwpwm]));
> + }
> + /* Calculate cnt_period based on resolution */
> cnt_period = DIV_ROUND_CLOSEST_ULL((u64)period_ns * 1000,
> resolution);
> }
> @@ -158,8 +179,13 @@ static int pwm_mediatek_config(struct pwm_chip *chip, struct pwm_device *pwm,
> reg_thres = PWM45THRES_FIXUP;
> }
>
> + /* Calculate cnt_duty based on resolution */
> cnt_duty = DIV_ROUND_CLOSEST_ULL((u64)duty_ns * 1000, resolution);
> - pwm_mediatek_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | clkdiv);
> + if (clksel)
> + pwm_mediatek_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | BIT(3) |
> + clkdiv);
> + else
> + pwm_mediatek_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | clkdiv);
> pwm_mediatek_writel(pc, pwm->hwpwm, reg_width, cnt_period);
> pwm_mediatek_writel(pc, pwm->hwpwm, reg_thres, cnt_duty);
>
>

\
 
 \ /
  Last update: 2020-03-07 22:28    [W:0.101 / U:5.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site