lkml.org 
[lkml]   [2020]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation


On Fri, 6 Mar 2020, Jarkko Sakkinen wrote:

> On Thu, Mar 05, 2020 at 09:30:13PM +0100, Lukas Bulwahn wrote:
> > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> > renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> > to trusted-keys/trusted_tpm1.c in security/keys/.
> >
> > Since then, ./scripts/get_maintainer.pl --self-test complains:
> >
> > warning: no file matches F: security/keys/trusted.c
> > warning: no file matches F: include/keys/trusted.h
> >
> > Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> > files in security/keys/trusted-keys/ are identified as part of
> > KEYS-TRUSTED.
> >
> > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> > Changes to v1:
> > - use a global pattern for matching the whole security/keys/trusted-keys/
> > directory.
> > Changes to v2:
> > - name the correct directory in the commit message
> >
> > Sumit, please ack.
> > Jarkko, please pick this patch v3.
>
> Please tell me why you emphasize the moment when a patch that does not
> fix a critical bug is picked?
>
> Do you have systems that break because the MAINTAINERS file is not
> updated?
>
> It will end up in v5.7 PR for sure but saying things like that is same
> as saying that there would be some catastrophically urgent need to still
> squeeze the patch into v5.6. Unless you actually have something critical
> in your hand, please stop doing that.
>

Got it. I did not intend to emphasize any urgency; I will not continue
to do that for patches of this clean-up type.

Lukas

\
 
 \ /
  Last update: 2020-03-06 21:51    [W:0.112 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site