lkml.org 
[lkml]   [2020]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/3] dt-bindings: leds: Shiji Lighting APA102C LED
From
Date
Hi Nicolas,

On 3/6/20 2:40 PM, Nicolas Belin wrote:
> Document Shiji Lighting APA102C LED driver device tree bindings.
>
> Signed-off-by: Nicolas Belin <nbelin@baylibre.com>
> ---
> .../devicetree/bindings/leds/leds-apa102c.yaml | 97 ++++++++++++++++++++++
> 1 file changed, 97 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-apa102c.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-apa102c.yaml b/Documentation/devicetree/bindings/leds/leds-apa102c.yaml
> new file mode 100644
> index 000000000000..21457fc3762d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-apa102c.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-apa102c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for Shiji Lighting - APA102C
> +
> +maintainers:
> + - Nicolas Belin <nbelin@baylibre.com>
> +
> +description:
> + Each RGB LED is represented as a rgb-led sub-node of the leds-apa102c
> + device. Each LED is a three color rgb LED with an additional 32 levels
> + brightness adjustment. They can be cascaded so that multiple LEDs can be set
> + with a single command.
> +
> +properties:
> + compatible:
> + const: shiji,apa102c
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^rgb-led@[0-9]+$":
> + type: object
> + description: |
> + Array of connected RGB LEDs.
> +
> + properties:
> + reg:
> + description: |
> + This property corresponds to the led index. It has to be between 0
> + and the number of managed leds minus 1
> + maxItems: 1
> +
> + label:

As mentioned before - don't use label and use function
and color properties instead.

> + description: |
> + This property corresponds to the name of the RGB led.
> + maxItems: 1
> +
> + linux,default-trigger: true
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + required:
> + - reg
> + - label
> + - '#address-cells'
> + - '#size-cells'
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> + - '#address-cells'
> + - '#size-cells'
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + led-controller@0 {
> + compatible = "shiji,apa102c";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + rgb-led@0 {

s/rgb-led/led/

> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + label = "rgb_led1";

Instead of label please use function and color properties.

E.g.

color = LED_COLOR_ID_RED;
function = LED_FUNCTION_STATUS;

If the function of your interest is not available in
include/dt-bindings/leds/common.h then you can propose one.

Please refer to Documentation/devicetree/bindings/leds/common.txt.


> + };
> + rgb-led@1 {

s/rgb-led/led/

> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + label = "rgb_led2";
> + };

You have to apply DT scheme from LED common bindings and have
separate child node for each color of RGB LED.

> + };
> + };
>

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2020-03-06 21:20    [W:0.090 / U:7.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site