lkml.org 
[lkml]   [2020]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/6] soc: Add Baikal-T1 SoC APB/AXI EHB and L2-cache drivers
On Fri, Mar 6, 2020 at 2:07 PM <Sergey.Semin@baikalelectronics.ru> wrote:
>
> From: Serge Semin <fancer.lancer@gmail.com>
>
> Aside from PCIe/SATA/DDR/I2C/CPU-reboot specific settings the Baikal-T1
> system controller provides three vendor-specific blocks. In particular
> there are two Errors Handler Blocks to detect and report an info regarding
> any problems discovered on the AXI and APB buses. These are the main buses
> utilized by the SoC devices to interact with each other. In addition there
> is a way to tune the MIPS P5600 CM2 L2-cache up by setting the Tag/Data/WS
> L2-to-RAM latencies. All of this functionality is implemented in the
> APB/AXI EHB and L2-cache control block drivers to be a part of the kernel soc
> subsystem (as being specific to the Baikal-T1 SoC) and introduced in the
> framework of this patchset.
>
> This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4:
> commit 98d54f81e36b ("Linux 5.6-rc4").

I have no objection to the drivers, but I wonder if these should be
in drivers/bus and drivers/memory instead of drivers/soc, which have
similar drivers already. The driver for the L2 cache is not really a
memory controller driver, but it may be close enough, and we
already have a couple of different things in there.

Arnd

\
 
 \ /
  Last update: 2020-03-06 16:20    [W:0.177 / U:3.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site