lkml.org 
[lkml]   [2020]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
Hi Randy,

On Thu, Mar 05, 2020 at 07:17:49PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
> symbols do not depend on DRM_RCAR_DU, the menu presentation is
> broken for these and following non-R-Car Kconfig symbols.
>
> Is it safe/appropriate to make all of these symbols depend on
> DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.

As those drivers are useless without DRM_RCAR_DU, I'm fine with this
change. It however prevents test-compiling those drivers when
DRM_RCAR_DU is disabled, but I see little reason to do so anyway, I
expect compile tests to aim for as large coverage as possible, and they
should thus enable DRM_RCAR_DU.

Would you like to submit a new version without this question, and
possibly addressing Geert's concern if you think it's appropriate, or
should I do so when applying ?

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Cc: Dave Airlie <airlied@linux.ie>
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
> +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
> @@ -24,6 +24,7 @@ config DRM_RCAR_CMM
> config DRM_RCAR_DW_HDMI
> tristate "R-Car DU Gen3 HDMI Encoder Support"
> depends on DRM && OF
> + depends on DRM_RCAR_DU
> select DRM_DW_HDMI
> help
> Enable support for R-Car Gen3 internal HDMI encoder.
> @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
> config DRM_RCAR_LVDS
> tristate "R-Car DU LVDS Encoder Support"
> depends on DRM && DRM_BRIDGE && OF
> + depends on DRM_RCAR_DU
> select DRM_PANEL
> select OF_FLATTREE
> select OF_OVERLAY
> @@ -47,4 +49,5 @@ config DRM_RCAR_VSP
>
> config DRM_RCAR_WRITEBACK
> bool
> + depends on DRM_RCAR_DU
> default y if ARM64

Is this one needed ? The symbol should not be shown in the kconfig menu
as it has no text.

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2020-03-06 15:29    [W:0.038 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site