[lkml]   [2020]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] regulator: pwm: Don't warn on probe deferral
On Fri, Mar 06, 2020 at 08:51:29AM +0100, Uwe Kleine-König wrote:

> I wonder if we should do something like:

> ret = some_call(some, args);
> if (ret) {
> if (emit_errmsg_for_err(ret))
> dev_err(dev, "some_call failed: %pE\n", ERR_PTR(ret));
> return ret;
> }

> and have emit_errmsg_for_err return true if ret != -EPROBE_DEFER or some
> kernel parameter is given.

There was some effort in the past to have a dev_probe_err() or something
which could have a similar implementation but that didn't end up going
anywhere I think. I do prefer the debug level log since it's much
easier to have the information there without having to ask for it, that
design would've supported that.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2020-03-06 13:35    [W:0.066 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site