Messages in this thread | | | Subject | Re: [PATCH] sched/fair: fix enqueue_task_fair warning | From | Dietmar Eggemann <> | Date | Fri, 6 Mar 2020 13:19:21 +0100 |
| |
On 06/03/2020 13:07, Vincent Guittot wrote: > On Fri, 6 Mar 2020 at 10:12, Vincent Guittot <vincent.guittot@linaro.org> wrote: >> >> On Thu, 5 Mar 2020 at 20:07, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote: >>> >>> On 05/03/2020 18:29, Vincent Guittot wrote:
[...]
> If it's fine for you, I'm going to add this in a new version of the patch
Yes, please do.
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
[...]
>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >>> index e9fd5379bb7e..5e03be046aba 100644 >>> --- a/kernel/sched/fair.c >>> +++ b/kernel/sched/fair.c >>> @@ -4627,11 +4627,17 @@ void unthrottle_cfs_rq(struct cfs_rq *cfs_rq) >>> break; >>> } >>> >>> - assert_list_leaf_cfs_rq(rq); >>> - >>> if (!se) >>> add_nr_running(rq, task_delta); >>> > > will add similar comment as for enqueue_task_fair
Sounds good.
[...]
| |