Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro | Date | Fri, 06 Mar 2020 10:27:44 +0100 |
| |
Hi Johan,
Am Freitag, 6. März 2020, 08:22:00 CET schrieb Johan Jonker: > Hi, > > Missing #address-cells, #size-cells > Can you still fix that? > > On 3/6/20 1:23 AM, Heiko Stuebner wrote: > > Am Mittwoch, 4. März 2020, 22:30:23 CET schrieb Tobias Schramm: > >> This commit adds initial dt support for the rk3399 based Pinebook Pro. > >> > >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > > > > applied for 5.7 > > > > Thanks > > Heiko > > > > > > > +&edp { > > + force-hpd; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&edp_hpd>; > > + status = "okay"; > > + > > + ports { > > #address-cells = <1>; > #size-cells = <0>; > > Don't forget that extra empty line here.
The edp ports node does get its address+size cells already from the main node in rk3399.dtsi, so isn't needed here.
Heiko
> > > > + edp_out: port@1 { > > + reg = <1>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + edp_out_panel: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&panel_in_edp>; > > + }; > > + }; > > + }; > > +}; > >
| |