Messages in this thread | | | From | "Rantala, Tommi T. (Nokia - FI/Espoo)" <> | Subject | Re: [PATCH 1/3] perf top: Fix stdio interface input handling with glibc 2.28+ | Date | Fri, 6 Mar 2020 07:47:41 +0000 |
| |
On Thu, 2020-03-05 at 11:49 -0300, Arnaldo Carvalho de Melo wrote: > Thanks for fixing this, I had stumbled on it at some point, but since > I mostly use the TUI interface, it fell thru the cracks. > > Do you prefer it over the TUI one?
The stdio interface is important for us, as we're building perf without s- lang. To reduce dependencies I assume... But the TUI interface is certainly nice, so maybe we should just include s-lang to get it.
-Tommi
> Thanks, tested and applied. > > - Arnaldo > > > Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com> > > --- > > tools/perf/builtin-top.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > > index f6dd1a63f159e..d2539b793f9d4 100644 > > --- a/tools/perf/builtin-top.c > > +++ b/tools/perf/builtin-top.c > > @@ -684,7 +684,9 @@ static void *display_thread(void *arg) > > delay_msecs = top->delay_secs * MSEC_PER_SEC; > > set_term_quiet_input(&save); > > /* trash return*/ > > - getc(stdin); > > + clearerr(stdin); > > + if (poll(&stdin_poll, 1, 0) > 0) > > + getc(stdin); > > > > while (!done) { > > perf_top__print_sym_table(top); > > -- > > 2.21.1 > >
| |