lkml.org 
[lkml]   [2020]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2]tty:serial:mvebu-uart:fix a wrong return
From
Date
On 05. 03. 20, 2:38, tangbin wrote:
> in this place, the function should return a
> negative value and the PTR_ERR already returns
> a negative,so return -PTR_ERR() is wrong.
>
> Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>

Acked-by: Jiri Slaby <jslaby@suse.cz>

> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index c12a12556..4e9a59071 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
>
> port->membase = devm_ioremap_resource(&pdev->dev, reg);
> if (IS_ERR(port->membase))
> - return -PTR_ERR(port->membase);
> + return PTR_ERR(port->membase);
>
> mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
> GFP_KERNEL);
>

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2020-03-05 07:10    [W:0.056 / U:12.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site