Messages in this thread | | | Date | Wed, 4 Mar 2020 21:56:27 -0800 | From | Tao Ren <> | Subject | Re: [PATCH] usb: gadget: aspeed: improve vhub port irq handling |
| |
On Thu, Mar 05, 2020 at 02:35:08PM +1100, Benjamin Herrenschmidt wrote: > On Wed, 2020-03-04 at 18:38 -0800, rentao.bupt@gmail.com wrote: > > From: Tao Ren <rentao.bupt@gmail.com> > > > > This patch evaluates vhub ports' irq mask before going through per- > > port > > irq handling one by one, which helps to speed up irq handling in case > > there is no port interrupt. > > > > Signed-off-by: Tao Ren <rentao.bupt@gmail.com> > > Looks reasonable, but did you try a find_next_bit() loop and whether > that's faster ?
Make sense. It should be more efficient especially when most ports are idle (and I guess it's a common case). Will try and send out v2 soon.
Cheers,
Tao
| |