[lkml]   [2020]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v1 1/1] sched/fair: do not preempt current task if it is going to call schedule()

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on arm64/for-next/core tip/auto-latest linus/master v5.6-rc4 next-20200305]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see]

base: a0f03b617c3b2644d3d47bf7d9e60aed01bd5b10
config: riscv-randconfig-a001-20200305 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.5.0
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <>

All warnings (new ones prefixed by >>):

In file included from arch/riscv/kernel/asm-offsets.c:10:0:
include/linux/sched.h: In function 'set_tsk_going_to_sched':
include/linux/sched.h:1776:27: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean 'TIF_NEED_RESCHED'?
set_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
include/linux/sched.h:1776:27: note: each undeclared identifier is reported only once for each function it appears in
include/linux/sched.h: In function 'clear_tsk_going_to_sched':
include/linux/sched.h:1781:29: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean 'TIF_NEED_RESCHED'?
clear_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
In file included from arch/riscv/include/asm/bug.h:9:0,
from include/linux/bug.h:5,
from arch/riscv/include/asm/current.h:13,
from include/linux/sched.h:12,
from arch/riscv/kernel/asm-offsets.c:10:
include/linux/sched.h: In function 'test_tsk_going_to_sched':
include/linux/sched.h:1786:44: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean 'TIF_NEED_RESCHED'?
return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
include/linux/compiler.h:33:34: note: in definition of macro '__branch_check__'
______r = __builtin_expect(!!(x), expect); \
>> include/linux/sched.h:1786:9: note: in expansion of macro 'unlikely'
return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
make[2]: *** [scripts/ arch/riscv/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1112: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
21 real 5 user 9 sys 70.27% cpu make prepare

vim +/unlikely +1786 include/linux/sched.h

1784 static inline int test_tsk_going_to_sched(struct task_struct *tsk)
1785 {
> 1786 return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
1787 }

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2020-03-05 14:35    [W:0.176 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site