Messages in this thread | | | Date | Thu, 5 Mar 2020 16:29:09 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4 3/4] Input: adp5589: unify ret & error variables |
| |
On Thu, Mar 05, 2020 at 03:14:04PM +0200, Alexandru Ardelean wrote: > Both variables are used mostly in the same way in the probe function. > Having both means that we need to copy 'ret' to 'error' before exiting, so > just use 'ret' everywhere. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > ---
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |