Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH v1 4/4] scsi: ufs-mediatek: remove delay for host enabling | Date | Thu, 5 Mar 2020 13:14:00 +0000 |
| |
Hi Stanley,
> > > MediaTek platform and UFS controller do not require the delay > for host enabling, thus remove it. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufs-mediatek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index 3b0e575d7460..ea3b5fd62492 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -258,6 +258,8 @@ static int ufs_mtk_init(struct ufs_hba *hba) I would expect to set whatever is needed for your host controller In ufshcd_vops_hce_enable_notify(hba, PRE_CHANGE), and not here.
Thanks, Avri
> if (err) > goto out_variant_clear; > > + hba->hba_enable_delay_us = 0; > + > /* Enable runtime autosuspend */ > hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND; > > -- > 2.18.0
| |