lkml.org 
[lkml]   [2020]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 03/13] kprobes: Add symbols for kprobe insn pages
On Wed, 4 Mar 2020 22:10:10 -0800
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:

> On Wed, Mar 4, 2020 at 10:01 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > >
> > > # perf probe __schedule
> > > Added new event:
> > > probe:__schedule (on __schedule)
> > > # cat /proc/kallsyms | grep '\[__builtin__kprobes\]'
> > > ffffffffc00d4000 t kprobe_insn_page [__builtin__kprobes]
> > > ffffffffc00d6000 t kprobe_optinsn_page [__builtin__kprobes]
> > >
> > > Note: This patch adds "__builtin__kprobes" as a module name in
> > > /proc/kallsyms for symbols for pages allocated for kprobes' purposes, even
> > > though "__builtin__kprobes" is not a module.
> >
> > Looks good to me.
> >
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> >
> > BTW, would you also make a patch to change [bpf] to [__builtin__bpf]?
>
> Please do not.
> There is nothing 'builtin' about bpf.

Hmm, so, would we reject bpf.ko to be loaded ?

Thank you,

--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2020-03-05 10:04    [W:0.064 / U:2.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site