lkml.org 
[lkml]   [2020]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv7 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation
On Fri, Feb 21, 2020 at 12:19:26PM +0200, Tero Kristo wrote:
> From: Suman Anna <s-anna@ti.com>
>
> An implementation for the rproc ops .da_to_va() has been added
> that provides the address translation between device addresses
> to kernel virtual addresses for internal RAMs present on that
> particular remote processor device. The implementation provides
> the translations based on the addresses parsed and stored during
> the probe.
>
> This ops gets invoked by the exported rproc_da_to_va() function
> and allows the remoteproc core's ELF loader to be able to load
> program data directly into the internal memories.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>

Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> ---
> v7:
> - minor kerneldoc updates
>
> drivers/remoteproc/omap_remoteproc.c | 40 ++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
> index 4f92b069f5d0..89084dd919ba 100644
> --- a/drivers/remoteproc/omap_remoteproc.c
> +++ b/drivers/remoteproc/omap_remoteproc.c
> @@ -247,10 +247,50 @@ static int omap_rproc_stop(struct rproc *rproc)
> return 0;
> }
>
> +/**
> + * omap_rproc_da_to_va() - internal memory translation helper
> + * @rproc: remote processor to apply the address translation for
> + * @da: device address to translate
> + * @len: length of the memory buffer
> + *
> + * Custom function implementing the rproc .da_to_va ops to provide address
> + * translation (device address to kernel virtual address) for internal RAMs
> + * present in a DSP or IPU device). The translated addresses can be used
> + * either by the remoteproc core for loading, or by any rpmsg bus drivers.
> + *
> + * Return: translated virtual address in kernel memory space on success,
> + * or NULL on failure.
> + */
> +static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, int len)
> +{
> + struct omap_rproc *oproc = rproc->priv;
> + int i;
> + u32 offset;
> +
> + if (len <= 0)
> + return NULL;
> +
> + if (!oproc->num_mems)
> + return NULL;
> +
> + for (i = 0; i < oproc->num_mems; i++) {
> + if (da >= oproc->mem[i].dev_addr && da + len <=
> + oproc->mem[i].dev_addr + oproc->mem[i].size) {
> + offset = da - oproc->mem[i].dev_addr;
> + /* __force to make sparse happy with type conversion */
> + return (__force void *)(oproc->mem[i].cpu_addr +
> + offset);
> + }
> + }
> +
> + return NULL;
> +}
> +
> static const struct rproc_ops omap_rproc_ops = {
> .start = omap_rproc_start,
> .stop = omap_rproc_stop,
> .kick = omap_rproc_kick,
> + .da_to_va = omap_rproc_da_to_va,
> };
>
> static const struct omap_rproc_mem_data ipu_mems[] = {
> --
> 2.17.1
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

\
 
 \ /
  Last update: 2020-03-04 18:37    [W:0.220 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site