lkml.org 
[lkml]   [2020]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/8] soundwire: bus_type: add master_device/driver support
From
Date


> Were the above lines agreed or not? Do you see driver for master devices
> or not? Greg was okay with as well as these patches but I am not okay
> with the driver part for master, so I would like to see that removed.
>
> Different reviewers can have different reasons.. I have given bunch of
> reasons here, BUT I have not seen a single technical reason why this
> cannot be done.

With all due respect, I consider Greg as THE reviewer for device/driver
questions. Your earlier proposal to use platform devices was rejected by
Greg, and we've lost an entire month in the process, so I am somewhat
dubious on your proposal not to use a driver.

If you want a technical objection, let me restate what I already mentioned:

If you look at the hierarchy, we have

PCI device -> PCI driver
soundwire_master_device0
soundwire_slave(s) -> codec driver
...
soundwire_master_deviceN
soundwire_slave(s) -> codec driver

You have not explained how I could possibly deal with power management
without having a driver for the master_device(s). The pm_ops need to be
inserted in a driver structure, which means we need a driver. And if we
need a driver, then we might as well have a real driver with .probe
.remove support, driver_register(), etc.

I really don't see what's broken or unnecessary with these patches.

I would also kindly ask that you stop using exclamation marks and what I
consider as hostile language. I've asked you multiple times, it's not
professional, sorry.

Regards
-Pierre

\
 
 \ /
  Last update: 2020-03-04 16:18    [W:0.121 / U:2.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site