lkml.org 
[lkml]   [2020]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 06/20] mm/thp: narrow lru locking
From
Date


在 2020/3/4 下午4:02, Kirill A. Shutemov 写道:
> On Mon, Mar 02, 2020 at 07:00:16PM +0800, Alex Shi wrote:
>> @@ -2564,6 +2565,9 @@ static void __split_huge_page(struct page *page, struct list_head *list,
>> xa_lock(&swap_cache->i_pages);
>> }
>>
>> + /* Lru list would be changed, don't care head's LRU bit. */
>> + spin_lock_irqsave(&pgdat->lru_lock, flags);
>> +
>> for (i = HPAGE_PMD_NR - 1; i >= 1; i--) {
>> __split_huge_page_tail(head, i, lruvec, list);
>> /* Some pages can be beyond i_size: drop them from page cache */
>
> You change locking order WRT i_pages lock. Is it safe?
>

Thanks Kirill,

I think so. and lock_dep/proving has no complain.

Any problem addressed?

Alex

\
 
 \ /
  Last update: 2020-03-04 09:53    [W:0.045 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site