lkml.org 
[lkml]   [2020]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 04/20] mm/thp: move lru_add_page_tail func to huge_memory.c
From
Date


在 2020/3/4 下午3:47, Kirill A. Shutemov 写道:
> On Mon, Mar 02, 2020 at 07:00:14PM +0800, Alex Shi wrote:
>> The func is only used in huge_memory.c, defining it in other file with a
>> CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird.
>>
>> Let's move it close user.
>
> I don't think it's strong enough justification. I would rather keep all
> lru helpers in one place.
>

Thanks for comments, Kirill,

If it's a common used func, yes.

But if you look into details of this func, it's thp used only func.

Thanks
Alex

\
 
 \ /
  Last update: 2020-03-04 09:16    [W:0.037 / U:62.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site