lkml.org 
[lkml]   [2020]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/12] spi: spi-fsl-dspi: Remove unused chip->void_write_data
    Date
    From: Vladimir Oltean <vladimir.oltean@nxp.com>

    This variable has been present since the initial submission of the
    driver, and held, for some reason, the value of zero, to be sent on the
    wire in the case there wasn't any TX buffer for the current transfer.

    Since quite a while now, however, it isn't doing anything at all.

    Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    ---
    drivers/spi/spi-fsl-dspi.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
    index 896d7a0f45b0..63ec1d634d08 100644
    --- a/drivers/spi/spi-fsl-dspi.c
    +++ b/drivers/spi/spi-fsl-dspi.c
    @@ -110,7 +110,6 @@

    struct chip_data {
    u32 ctar_val;
    - u16 void_write_data;
    };

    enum dspi_trans_mode {
    @@ -235,7 +234,6 @@ struct fsl_dspi {
    const void *tx;
    void *rx;
    void *rx_end;
    - u16 void_write_data;
    u16 tx_cmd;
    u8 bits_per_word;
    u8 bytes_per_word;
    @@ -795,8 +793,6 @@ static int dspi_transfer_one_message(struct spi_controller *ctlr,
    dspi->tx_cmd |= SPI_PUSHR_CMD_CONT;
    }

    - dspi->void_write_data = dspi->cur_chip->void_write_data;
    -
    dspi->tx = transfer->tx_buf;
    dspi->rx = transfer->rx_buf;
    dspi->rx_end = dspi->rx + transfer->len;
    @@ -897,8 +893,6 @@ static int dspi_setup(struct spi_device *spi)
    sck_cs_delay = pdata->sck_cs_delay;
    }

    - chip->void_write_data = 0;
    -
    clkrate = clk_get_rate(dspi->clk);
    hz_to_spi_baud(&pbr, &br, spi->max_speed_hz, clkrate);

    --
    2.17.1
    \
     
     \ /
      Last update: 2020-03-04 23:02    [W:4.037 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site