Messages in this thread | | | Subject | Re: [PATCH V2 1/3] soc/tegra: fuse: Add custom SoC attributes | From | Dmitry Osipenko <> | Date | Tue, 31 Mar 2020 17:46:04 +0300 |
| |
31.03.2020 16:56, Jon Hunter пишет: ... >>> +static DEVICE_ATTR(minorrev, S_IRUGO, tegra_soc_minorrev_show, NULL); >> >> Checkpatch should give a warning about that permission isn't in octal >> format, please don't ignore it. > > Indeed. Will fix. I thought I had ran this previously, obviously not.
Also, please use DEVICE_ATTR_RO().
| |