lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 106/155] gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 BYT + AXP288 model
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    commit 0e91506ba00730f088961a8d39f8693b0f8e3fea upstream.

    Commit aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option +
    quirk mechanism") was added to deal with spurious wakeups on one specific
    model of the HP x2 10 series. In the mean time I have learned that there
    are at least 3 different HP x2 10 models:

    Bay Trail SoC + AXP288 PMIC
    Cherry Trail SoC + AXP288 PMIC
    Cherry Trail SoC + TI PMIC

    And the original quirk is only correct for (and only matches the)
    Cherry Trail SoC + TI PMIC model.

    The Bay Trail SoC + AXP288 PMIC model has different DMI strings, has
    the external EC interrupt on a different GPIO pin and only needs to ignore
    wakeups on the EC interrupt, the INT0002 device works fine on this model.

    This commit adds an extra DMI based quirk for the HP x2 10 BYT + AXP288
    model, ignoring wakeups for ACPI GPIO events on the EC interrupt pin
    on this model. This fixes spurious wakeups from suspend on this model.

    Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism")
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20200302111225.6641-3-hdegoede@redhat.com
    Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpio/gpiolib-acpi.c | 15 +++++++++++++++
    1 file changed, 15 insertions(+)

    --- a/drivers/gpio/gpiolib-acpi.c
    +++ b/drivers/gpio/gpiolib-acpi.c
    @@ -1415,6 +1415,21 @@ static const struct dmi_system_id gpioli
    .ignore_wake = "INT33FF:01@0,INT0002:00@2",
    },
    },
    + {
    + /*
    + * HP X2 10 models with Bay Trail SoC + AXP288 PMIC use an
    + * external embedded-controller connected via I2C + an ACPI GPIO
    + * event handler on INT33FC:02 pin 28, causing spurious wakeups.
    + */
    + .matches = {
    + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
    + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion x2 Detachable"),
    + DMI_MATCH(DMI_BOARD_NAME, "815D"),
    + },
    + .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
    + .ignore_wake = "INT33FC:02@28",
    + },
    + },
    {} /* Terminating entry */
    };


    \
     
     \ /
      Last update: 2020-03-31 11:19    [W:4.854 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site