lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 005/170] mmc: sdhci-tegra: Fix busy detection by enabling MMC_CAP_NEED_RSP_BUSY
    Date
    From: Ulf Hansson <ulf.hansson@linaro.org>

    [ Upstream commit d2f8bfa4bff5028bc40ed56b4497c32e05b0178f ]

    It has turned out that the sdhci-tegra controller requires the R1B response,
    for commands that has this response associated with them. So, converting
    from an R1B to an R1 response for a CMD6 for example, leads to problems
    with the HW busy detection support.

    Fix this by informing the mmc core about the requirement, via setting the
    host cap, MMC_CAP_NEED_RSP_BUSY.

    Reported-by: Bitan Biswas <bbiswas@nvidia.com>
    Reported-by: Peter Geis <pgwipeout@gmail.com>
    Suggested-by: Sowjanya Komatineni <skomatineni@nvidia.com>
    Cc: <stable@vger.kernel.org>
    Tested-by: Sowjanya Komatineni <skomatineni@nvidia.com>
    Tested-By: Peter Geis <pgwipeout@gmail.com>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/sdhci-tegra.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
    index 403ac44a73782..a25c3a4d3f6cb 100644
    --- a/drivers/mmc/host/sdhci-tegra.c
    +++ b/drivers/mmc/host/sdhci-tegra.c
    @@ -1552,6 +1552,9 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
    if (tegra_host->soc_data->nvquirks & NVQUIRK_ENABLE_DDR50)
    host->mmc->caps |= MMC_CAP_1_8V_DDR;

    + /* R1B responses is required to properly manage HW busy detection. */
    + host->mmc->caps |= MMC_CAP_NEED_RSP_BUSY;
    +
    tegra_sdhci_parse_dt(host);

    tegra_host->power_gpio = devm_gpiod_get_optional(&pdev->dev, "power",
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-03-31 11:03    [W:4.300 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site