Messages in this thread | | | Date | Mon, 30 Mar 2020 13:49:12 -0300 | From | Jason Gunthorpe <> | Subject | Re: [RFC PATCH v1 01/50] IB/qib: Delete struct qib_ivdev.qp_rnd |
| |
On Mon, Mar 30, 2020 at 04:43:33PM +0000, George Spelvin wrote: > On Mon, Mar 30, 2020 at 02:28:08PM +0100, Mark Rutland wrote: > > Also, if you do send a series, *please* add a cover-letter explaining > > what the overall purpose of the series is, and have all patches chained > > in-reply-to that rather than patch 1. Otherwise reviewers have to > > reverse-engineer the intent of the author. > > > > You can generate the cover letter with: > > > > $ git format-patch --cover $FROM..$TO > > > > ... and IIRC git send-email does the right thing by default if you hand > > it all of the patches at once. > > Er, I *did* send a cover letter. Cc:ed to the union of everyone > Cc:ed on any of the individual patches. It's appended. (I left in > the full Cc: list so you can see you're on it.) > > My problem is I don't have git on my e-mail machine, so I fed them to > sendmail manually, and that does some strange things.
The problem is that none of the patches had a in-reply-to header to the cover letter so it is very difficult to find it.
Things work best if you can use git send-email :) I've never tried it, bu I wonder if you can tell git that the sendmail is 'ssh foo-server /usr/bin/sendmail' ?
Jason
| |