Messages in this thread | | | Date | Mon, 30 Mar 2020 17:21:30 +0100 | From | Russell King - ARM Linux admin <> | Subject | Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY |
| |
On Mon, Mar 30, 2020 at 06:17:40PM +0200, Andrew Lunn wrote: > On Mon, Mar 30, 2020 at 07:01:36PM +0300, Codrin Ciubotariu wrote: > > Some ethernet controllers, such as cadence's macb, have an embedded MDIO. > > For this reason, the ethernet PHY nodes are not under an MDIO bus, but > > directly under the ethernet node. > > Hi Codrin > > That is deprecated. It causes all sorts of problems putting PHY nodes > in the MAC without a container. > > Please fix macb to look for an mdio node, and place your fixed link > inside it.
Seems wrong.
fixed links have never needed to be under a mdio node - see Documentation/devicetree/bindings/net/ethernet-controller.yaml
fixed-link is a child of the MAC controller, not of a mdio node.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
| |