Messages in this thread | | | Date | Mon, 30 Mar 2020 19:58:33 +0530 | From | kgunda@codeauro ... | Subject | Re: [PATCH V4 3/4] backlight: qcom-wled: Add WLED5 bindings |
| |
On 2020-03-25 21:07, Daniel Thompson wrote: > On Mon, Mar 23, 2020 at 11:16:57PM +0530, Kiran Gunda wrote: >> Add WLED5 specific bindings. >> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> >> Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org> >> --- >> .../bindings/leds/backlight/qcom-wled.yaml | 39 >> ++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> index 8a388bf..159115f 100644 >> --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> @@ -20,6 +20,7 @@ properties: >> - qcom,pm8941-wled >> - qcom,pmi8998-wled >> - qcom,pm660l-wled >> + - qcom,pm8150l-wled >> >> reg: >> maxItems: 1 >> @@ -28,10 +29,23 @@ properties: >> maxItems: 1 >> description: >> brightness value on boot, value from 0-4095. >> + For pm8150l this value vary from 0-4095 or 0-32767 >> + depending on the brightness control mode. If CABC is >> + enabled 0-4095 range is used. > > I rather dislike some of the property descriptions using PMIC version > numbers to distinguish between peripheral versions and others using > WLEDx version numbers. > > Could the property description be rephrased to use WLED3/4/5 > terminology > instead? > Sure. I will modify in the next post. > >> allOf: >> - $ref: /schemas/types.yaml#/definitions/uint32 >> default: 2048 >> >> + max-brightness: >> + maxItems: 1 >> + description: >> + Maximum brightness level. Allowed values are, >> + for pmi8998 it is 0-4095. >> + For pm8150l, this can be either 4095 or 32767. >> + If CABC is enabled, this is capped to 4095. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + > > Similar thing here, is PMI8998 simply a synonym for WLED4 or there > something special about the PMIC versioning that requires it to be > used? > > > Daniel. > Sure. It is synonym for WLED4. I will modify in the next post. > >> label: >> maxItems: 1 >> description: >> @@ -124,6 +138,31 @@ properties: >> value for PM8941 from 1 to 3. Default 2 >> For PMI8998 from 1 to 4. >> >> + qcom,modulator-sel: >> + maxItems: 1 >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Selects the modulator used for brightness modulation. >> + Allowed values are, >> + 0 - Modulator A >> + 1 - Modulator B >> + If not specified, then modulator A will be used by default. >> + This property is applicable only to WLED5 peripheral. >> + >> + qcom,cabc-sel: >> + maxItems: 1 >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Selects the CABC pin signal used for brightness modulation. >> + Allowed values are, >> + 0 - CABC disabled >> + 1 - CABC 1 >> + 2 - CABC 2 >> + 3 - External signal (e.g. LPG) is used for dimming >> + This property is applicable only to WLED5 peripheral. >> + >> interrupts: >> maxItems: 2 >> description: >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project
| |