lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: nfsd: fileache.c: Use built-in RCU list checking
Applying for 5.7, thanks.--b.

On Thu, Feb 13, 2020 at 08:33:59PM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> ---
> fs/nfsd/filecache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 32a9bf22ac08..547d2d8bde62 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -736,7 +736,7 @@ nfsd_file_find_locked(struct inode *inode, unsigned int may_flags,
> unsigned char need = may_flags & NFSD_FILE_MAY_MASK;
>
> hlist_for_each_entry_rcu(nf, &nfsd_file_hashtbl[hashval].nfb_head,
> - nf_node) {
> + nf_node, lockdep_is_held(&nfsd_file_hashtbl[hashval].nfb_lock)) {
> if ((need & nf->nf_may) != need)
> continue;
> if (nf->nf_inode != inode)
> --
> 2.17.1

\
 
 \ /
  Last update: 2020-03-03 17:55    [W:0.049 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site