lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 76/87] drivers: net: xgene: Fix the order of the arguments of alloc_etherdev_mqs()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit 5a44c71ccda60a50073c5d7fe3f694cdfa3ab0c2 upstream.

    'alloc_etherdev_mqs()' expects first 'tx', then 'rx'. The semantic here
    looks reversed.

    Reorder the arguments passed to 'alloc_etherdev_mqs()' in order to keep
    the correct semantic.

    In fact, this is a no-op because both XGENE_NUM_[RT]X_RING are 8.

    Fixes: 107dec2749fe ("drivers: net: xgene: Add support for multiple queues")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
    +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
    @@ -2034,7 +2034,7 @@ static int xgene_enet_probe(struct platf
    int ret;

    ndev = alloc_etherdev_mqs(sizeof(struct xgene_enet_pdata),
    - XGENE_NUM_RX_RING, XGENE_NUM_TX_RING);
    + XGENE_NUM_TX_RING, XGENE_NUM_RX_RING);
    if (!ndev)
    return -ENOMEM;


    \
     
     \ /
      Last update: 2020-03-03 19:03    [W:2.260 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site