lkml.org 
[lkml]   [2020]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 1/2] mm/memory_hotplug: simplify calculation of number of pages in __remove_pages()
Date


> Am 29.03.2020 um 22:10 schrieb Linus Torvalds <torvalds@linux-foundation.org>:
>
> On Sun, Mar 29, 2020 at 12:19 PM David Hildenbrand <david@redhat.com> wrote:
>>
>> This patch seems to have another of these weird MIME crap in it. (my
>> other patches in -next seem to be fine)
>>
>> See
>>
>> https://lore.kernel.org/linux-mm/20200228095819.10750-2-david@redhat.com/raw
>
> That email actually looks fine.
>
> Yes, it has that
>
> fro=
> m
>
> pattern, but it also has
>
> Content-Transfer-Encoding: quoted-printable
>
> so the recipient should be doing the right thing with that pattern.
>
> The patch itself also has MIME encoding in it:
>
> - cur_nr_pages =3D min(end_pfn - pfn, -(pfn | PAGE_SECTION_MASK));
> + cur_nr_pages =3D min(end_pfn - pfn,
>
> so the patch wouldn't even apply unless the recipient did the proper
> MIME decode of the message.
>
> That's also why the non-raw message looks fine:
>
> https://lore.kernel.org/linux-mm/20200228095819.10750-2-david@redhat.com/
>
> because the raw message data has the proper encoding information.
>
> In contrast, look at the email that Andrew sent me and that I complained about:
>
> https://lore.kernel.org/linux-mm/20200329021719.MBKzW0xSl%25akpm@linux-foundation.org/
>
> and notice how that *non-raw* email has that
>
> Withou=
> t
>
> pattern in it. And when you look at the raw one:
>
> https://lore.kernel.org/linux-mm/20200329021719.MBKzW0xSl%25akpm@linux-foundation.org/raw
>
> it has no content transfer encoding line in the headers.

Interesting, at least the patch in -next is messed up. I remember Andrew adapted some scripts, maybe this is a leftover.

Cheers!

>
> Linus
>

\
 
 \ /
  Last update: 2020-03-29 22:18    [W:0.079 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site