Messages in this thread | | | Date | Fri, 27 Mar 2020 20:45:32 +0100 | From | Michal Kubecek <> | Subject | Re: [PATCH net-next v2 12/12] ethtool: provide timestamping information with TIMESTAMP_GET request |
| |
On Fri, Mar 27, 2020 at 11:56:13AM -0700, Richard Cochran wrote: > On Fri, Mar 27, 2020 at 03:08:17PM +0100, Michal Kubecek wrote: > > +/* TIMESTAMP */ > > + > > +enum { > > + ETHTOOL_A_TIMESTAMP_UNSPEC, > > I suggest using ETHTOOL_A_TSINFO_ throughout. After all, this API > does not provide time stamps, and we want to avoid confusion.
I'll send v3 with *_TSINFO_*, "onestep-sync" and "onestep-p2p".
Michal
> > + ETHTOOL_A_TIMESTAMP_HEADER, /* nest - _A_HEADER_* */ > > + ETHTOOL_A_TIMESTAMP_TIMESTAMPING, /* bitset */ > > + ETHTOOL_A_TIMESTAMP_TX_TYPES, /* bitset */ > > + ETHTOOL_A_TIMESTAMP_RX_FILTERS, /* bitset */ > > + ETHTOOL_A_TIMESTAMP_PHC_INDEX, /* u32 */ > > + > > + /* add new constants above here */ > > + __ETHTOOL_A_TIMESTAMP_CNT, > > + ETHTOOL_A_TIMESTAMP_MAX = (__ETHTOOL_A_TIMESTAMP_CNT - 1) > > +}; > > Acked-by: Richard Cochran <richardcochran@gmail.com>
| |