lkml.org 
[lkml]   [2020]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH v1] driver core: Set fw_devlink to "permissive" behavior by default
    On Fri, Mar 27, 2020 at 8:21 AM Greg Kroah-Hartman
    <gregkh@linuxfoundation.org> wrote:
    >
    > On Fri, Mar 27, 2020 at 11:25:48AM +0100, Marek Szyprowski wrote:
    > > Hi,
    > >
    > > On 2020-03-21 22:03, Saravana Kannan wrote:
    > > > Set fw_devlink to "permissive" behavior by default so that device links
    > > > are automatically created (with DL_FLAG_SYNC_STATE_ONLY) by scanning the
    > > > firmware.
    > > >
    > > > This ensures suppliers get their sync_state() calls only after all their
    > > > consumers have probed successfully. Without this, suppliers will get
    > > > their sync_state() calls at late_initcall_sync() even if their consuer
    > > >
    > > > Ideally, we'd want to set fw_devlink to "on" or "rpm" by default. But
    > > > that needs more testing as it's known to break some corner case
    > > > drivers/platforms.
    > > >
    > > > Cc: Rob Herring <robh+dt@kernel.org>
    > > > Cc: Frank Rowand <frowand.list@gmail.com>
    > > > Cc: devicetree@vger.kernel.org
    > > > Signed-off-by: Saravana Kannan <saravanak@google.com>
    > >
    > > This patch has just landed in linux-next 20200326. Sadly it breaks
    > > booting of the Raspberry Pi3b and Pi4 boards, either in 32bit or 64bit
    > > mode. There is no warning nor panic message, just a silent freeze. The
    > > last message shown on the earlycon is:
    > >
    > > [ 0.893217] Serial: 8250/16550 driver, 1 ports, IRQ sharing enabled

    Marek,

    Any chance you could get me a stack trace for when it's stuck? That'd
    be super helpful and I'd really appreciate it. Is it working fine on
    other variants of Raspberry?

    >
    > I've just reverted this for now.
    >

    Greg,

    I have no problem with reverting this. If there's any other
    tree/branch you can put this on where it could get more testing and
    reporting of issues, that'd be great.

    -Saravana

    \
     
     \ /
      Last update: 2020-03-27 19:32    [W:3.601 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site