Messages in this thread Patch in this message | | | From | Julien Thierry <> | Subject | [PATCH v2 04/10] objtool: check: Ignore empty alternative groups | Date | Fri, 27 Mar 2020 15:28:41 +0000 |
| |
Atlernative section can contain entries for alternatives with no instructions. Objtool will currently crash when handling such an entry.
Just skip that entry, but still give a warning to discourage useless entries.
Signed-off-by: Julien Thierry <jthierry@redhat.com> --- tools/objtool/check.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 74353b2c39ce..5c03460f1f07 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -904,6 +904,12 @@ static int add_special_section_alts(struct objtool_file *file) } if (special_alt->group) { + if (!special_alt->orig_len) { + WARN_FUNC("empty alternative entry", + orig_insn->sec, orig_insn->offset); + continue; + } + ret = handle_group_alt(file, special_alt, orig_insn, &new_insn); if (ret) -- 2.21.1
| |