lkml.org 
[lkml]   [2020]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner()
On Thu, 26 Mar 2020, Michel Lespinasse wrote:

>Add a couple APIs to allow splitting mmap_read_unlock() into two calls:
>- mmap_read_release(), called by the task that had taken the mmap lock;
>- mmap_read_unlock_non_owner(), called from a work queue.
>
>These apis are used by kernel/bpf/stackmap.c only.

I'm not crazy about the idea generalizing such calls into an mm api.
We try to stay away from non-owner semantics in locking - granted
the IS_ENABLED(CONFIG_PREEMPT_RT) warning, but still.

Could this give future users the wrong impression? What about just
using rwsem calls directly in bpf?

Thanks,
Davidlohr

\
 
 \ /
  Last update: 2020-03-27 05:49    [W:0.150 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site