lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 7/9] net: phy: enable qoriq backplane support
From
Date
On Thu, 2020-03-26 at 21:13 +0100, Andrew Lunn wrote:
> > > +static int qoriq_backplane_config_init(struct phy_device *bpphy)
> > > +{
> > []
> > > + for (i = 0; i < bp_phy->num_lanes; i++) {
> > []
> > > + ret = of_address_to_resource(lane_node, 0, &res);
> > > + if (ret) {
> > > + bpdev_err(bpphy,
> > > + "could not obtain lane memory map for index=%d, ret = %d\n",
> > > + i, ret);
> > > + return ret;
> >
> > This could use the new vsprintf %pe extension:
>
> Hi Joe

Hello Andrew.

> Probably a FAQ. But is there plans to extend vsprintf to take an int
> errno value, rather than having to do this ugly ERR_PTR(ret) every
> time? Format string %de ?

Uwe Kleine-König proposed one a couple times.

https://lkml.org/lkml/2019/8/27/1456

Though I believe one %<type><extra> extension mechanism
in vsprintf is enough. At least the %p<foo> use is
unlikely to ever have desired but dropped output after
an output of %p. It seems less true for %[diux].




\
 
 \ /
  Last update: 2020-03-26 21:30    [W:0.096 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site