lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] kunit: tool: add missing test data file content
From
Date
On 3/23/20 8:56 PM, David Gow wrote:
> On Mon, Mar 23, 2020 at 12:22 PM Brendan Higgins
> <brendanhiggins@google.com> wrote:
>>
>> Add a missing raw dmesg test log to test the kunit_tool's dmesg parser.
>> test_prefix_poundsign and test_output_with_prefix_isolated_correctly
>> fail without this test log.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Tested-by: David Gow <davidgow@google.com>
>
> This patch does indeed fix the kunit_tool's unit tests (run with
> ./tools/testing/kunit/kunit_tool_test.py).
>
> Beforehand, it failed with the errors below:
> ======================================================================
> ERROR: test_prefix_poundsign (__main__.KUnitParserTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "./tools/testing/kunit/kunit_tool_test.py", line 208, in
> test_prefix_poundsign
> self.assertEqual('kunit-resource-test', result.suites[0].name)
> IndexError: list index out of range
>
> ======================================================================
> FAIL: test_output_with_prefix_isolated_correctly
> (__main__.KUnitParserTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "./tools/testing/kunit/kunit_tool_test.py", line 116, in
> test_output_with_prefix_isolated_correctly
> self.assertContains('TAP version 14\n', result)
> File "./tools/testing/kunit/kunit_tool_test.py", line 96, in
> assertContains
> str(needle) + '" not found in "' + str(haystack) + '"!')
> AssertionError: "TAP version 14
> " not found in "<generator object isolate_kunit_output at 0x7f4e88d85ed0>"!
>
> ----------------------------------------------------------------------
> Ran 20 tests in 0.022s
>
> FAILED (failures=1, errors=1)
>

Applied to linux-kselftest kunit for Linux 5.7-rc1.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-03-26 21:17    [W:0.053 / U:4.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site