lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 6/9] net: phy: add backplane kr driver support
From
Date
On Thu, 2020-03-26 at 12:07 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Thu, 26 Mar 2020 11:55:17 -0700
>
> > On Thu, 2020-03-26 at 11:53 -0700, David Miller wrote:
> >> From: Florinel Iordache <florinel.iordache@nxp.com>
> >> Date: Thu, 26 Mar 2020 15:51:19 +0200
> >>
> >> > +static void kr_reset_master_lane(struct kr_lane_info *krln)
> >> > +{
> >> > + struct phy_device *bpphy = krln->bpphy;
> >> > + struct backplane_phy_info *bp_phy = bpphy->priv;
> >> > + const struct lane_io_ops *lane_ops = krln->bp_phy->bp_dev.lane_ops;
> >>
> >> Please use reverse christmas tree ordering for local variables.
> >
> > How (any why) do you suggest the first 2 entries here
> > should be ordered?
>
> You have to sometimes put assignments into the code body rather than
> the declarations in situations like this.

No "why" reply given.

An option is not using reverse christmas tree to both
avoid ordering
constraints and reduce overall line count.

I think this is your own personal taste rather than an
actual valuable addition for subsystem maintenance.

And if this a serious requirement for the subsystem
you oversee, you should add it to something like a
maintainer-entry-profile with a "P:" line in MAINTAINERS.

https://www.kernel.org/doc/html/latest/maintainer/maintainer-entry-profile.html



\
 
 \ /
  Last update: 2020-03-26 20:45    [W:0.039 / U:9.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site