lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH bpf-next v7 7/8] bpf: lsm: Add selftests for BPF_PROG_TYPE_LSM
On 26-Mär 12:24, Andrii Nakryiko wrote:
> On Thu, Mar 26, 2020 at 7:30 AM KP Singh <kpsingh@chromium.org> wrote:
> >
> > From: KP Singh <kpsingh@google.com>
> >
> > * Load/attach a BPF program that hooks to file_mprotect (int)
> > and bprm_committed_creds (void).
> > * Perform an action that triggers the hook.
> > * Verify if the audit event was received using the shared global
> > variables for the process executed.
> > * Verify if the mprotect returns a -EPERM.
> >
> > Signed-off-by: KP Singh <kpsingh@google.com>
> > Reviewed-by: Brendan Jackman <jackmanb@google.com>
> > Reviewed-by: Florent Revest <revest@google.com>
> > Reviewed-by: Thomas Garnier <thgarnie@google.com>
> > ---
>
> Please fix endlines below. With that:
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
> > tools/testing/selftests/bpf/config | 2 +
> > .../selftests/bpf/prog_tests/test_lsm.c | 86 +++++++++++++++++++
> > tools/testing/selftests/bpf/progs/lsm.c | 48 +++++++++++
> > 3 files changed, 136 insertions(+)
> > create mode 100644 tools/testing/selftests/bpf/prog_tests/test_lsm.c
> > create mode 100644 tools/testing/selftests/bpf/progs/lsm.c
> >
>
> [...]
>
> > +void test_test_lsm(void)
> > +{
> > + struct lsm *skel = NULL;
> > + int err, duration = 0;
> > +
> > + skel = lsm__open_and_load();
> > + if (CHECK(!skel, "skel_load", "lsm skeleton failed\n"))
> > + goto close_prog;
> > +
> > + err = lsm__attach(skel);
> > + if (CHECK(err, "attach", "lsm attach failed: %d\n", err))
> > + goto close_prog;
> > +
> > + err = exec_cmd(&skel->bss->monitored_pid);
> > + if (CHECK(err < 0, "exec_cmd", "err %d errno %d\n", err, errno))
> > + goto close_prog;
> > +
> > + CHECK(skel->bss->bprm_count != 1, "bprm_count", "bprm_count = %d",
>
> \n is missing

Done.

>
> > + skel->bss->bprm_count);
> > +
> > + skel->bss->monitored_pid = getpid();
> > +
> > + err = heap_mprotect();
> > + if (CHECK(errno != EPERM, "heap_mprotect", "want errno=EPERM, got %d\n",
> > + errno))
> > + goto close_prog;
> > +
> > + CHECK(skel->bss->mprotect_count != 1, "mprotect_count",
> > + "mprotect_count = %d", skel->bss->mprotect_count);
>
> \n is missing

Done.

- KP

>
> > +
> > +close_prog:
> > + lsm__destroy(skel);
> > +}
>
> [...]

\
 
 \ /
  Last update: 2020-03-26 20:44    [W:0.109 / U:28.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site