lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 08/27] ata: optimize ata_scsi_rbuf[] size
    Date
    Currently the maximum required size of the ata_scsi_rbuf[] is
    576 bytes in ata_scsiop_inq_89() so modify ATA_SCSI_RBUF_SIZE
    define accordingly.

    Code size savings on m68k arch using (modified) atari_defconfig:

    text data bss dec hex filename
    before:
    20782 105 4096 24983 6197 drivers/ata/libata-scsi.o
    after:
    20782 105 576 21463 53d7 drivers/ata/libata-scsi.o

    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    ---
    drivers/ata/libata-scsi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
    index 0912acb82b80..c2b8428dfb94 100644
    --- a/drivers/ata/libata-scsi.c
    +++ b/drivers/ata/libata-scsi.c
    @@ -37,7 +37,7 @@
    #include "libata.h"
    #include "libata-transport.h"

    -#define ATA_SCSI_RBUF_SIZE 4096
    +#define ATA_SCSI_RBUF_SIZE 576

    static DEFINE_SPINLOCK(ata_scsi_rbuf_lock);
    static u8 ata_scsi_rbuf[ATA_SCSI_RBUF_SIZE];
    --
    2.24.1
    \
     
     \ /
      Last update: 2020-03-26 16:59    [W:2.486 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site