lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 2/6] PCI: iproc: Add INTx support with better modeling
On Thu, Mar 26, 2020 at 7:49 AM Srinath Mannam
<srinath.mannam@broadcom.com> wrote:
> -static void iproc_pcie_enable(struct iproc_pcie *pcie)
> +static void iproc_pcie_mask_irq(struct irq_data *d)
> {
> + struct iproc_pcie *pcie = irq_data_get_irq_chip_data(d);
> + u32 val;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&pcie->intx_lock, flags);
> + val = iproc_pcie_read_reg(pcie, IPROC_PCIE_INTX_EN);
> + val &= ~(BIT(irqd_to_hwirq(d)));
> + iproc_pcie_write_reg(pcie, IPROC_PCIE_INTX_EN, val);
> + spin_unlock_irqrestore(&pcie->intx_lock, flags);
> +}

I think these need to use a raw spinlock, or you get problems with
PREEMPT_RT

Arnd

\
 
 \ /
  Last update: 2020-03-26 13:35    [W:0.256 / U:6.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site