lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 19/27] ata: move sata_link_{debounce,resume}() to libata-sata.c
On Tue, Mar 17, 2020 at 03:43:25PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move sata_link_{debounce,resume}() to libata-sata.c
>
> * add static inline for CONFIG_SATA_HOST=n case (only one,
> for sata_link_resume() is needed)

This looks good for now:

Reviewed-by: Christoph Hellwig <hch@lst.de>

But as a follow on I think it would make sene to just split
ata_std_prereset into a pata and a sata version, and then we don't
even need the non-static and potentially stubeed out sata_link_resume.

\
 
 \ /
  Last update: 2020-03-26 10:56    [W:0.189 / U:53.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site