lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/4] mfd: anx7688: Add driver for Analogix ANX7688 chip
On Wed, 18 Mar 2020, Enric Balletbo i Serra wrote:

> The ANX7688 chip is a Type-C Port Controller, HDMI to DP converter and
> USB-C mux between USB 3.0 lanes and the DP output.
>
> For our use case a big part of the chip, like power supplies, control
> gpios and usb-c parts are managed by an Embedded Controller, hence,
> this is its simplest form of it. Other users of this chip might
> introduce new functionalities as per their requirements.

Hmm... So first impressions is that this 'driver' doesn't really do
anything useful other than checking the running model. I think you're
better off using "simple-mfd" and doing the ID check inside the
useful/functional child device driver(s).

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/mfd/Kconfig | 11 +++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/anx7688.c | 87 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/anx7688.h | 39 +++++++++++++++++
> 4 files changed, 138 insertions(+)
> create mode 100644 drivers/mfd/anx7688.c
> create mode 100644 include/linux/mfd/anx7688.h

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2020-03-26 10:30    [W:0.058 / U:1.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site