lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema
Hi Shimoda-san,

On Thu, Mar 26, 2020 at 6:30 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation
> to json-schema.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: GPL-2.0-only

I think Rob would prefer to see

# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> + reg:
> + # base address and length of the registers block for the PHY.

The comment is not needed.

> + maxItems: 1
> +
> + clocks:
> + # clock phandle and specifier pair(s).

Likewise.

> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + # for RZ/A2

if:
properties:
compatible:
items:
enum:
- renesas,usb2-phy-r7s9210

> + minItems: 1
> + maxItems: 2
> + items:
> + - const: fck
> + - const: usb_x1

> +examples:
> + - |
> + #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + usb-phy@ee080200 {
> + compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> + reg = <0 0xee080200 0 0x700>;

Examples are built with #{address,size}-cells = <1>, so

reg = <0xee080200 0x700>;

> + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 703>;
> + #phy-cells = <1>;
> + };
> +
> + usb-phy@ee0a0200 {
> + compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> + reg = <0 0xee0a0200 0 0x700>;

reg = <0xee0a0200 0x700>;

> + clocks = <&cpg CPG_MOD 702>;
> + #phy-cells = <1>;
> + };

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-03-26 10:01    [W:0.042 / U:1.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site