lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/4] dt-bindings: phy: renesas: usb3-phy: convert bindings to json-schema
Hi Shimoda-san,

On Thu, Mar 26, 2020 at 6:29 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Convert Renesas R-Car generation 3 USB 3.0 PHY bindings documentation
> to json-schema.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb3-phy.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0-only

In think Rob would prefer

# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/renesas,usb3-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car generation 3 USB 3.0 PHY
> +
> +maintainers:
> + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - renesas,r8a774a1-usb3-phy # RZ/G2M
> + - renesas,r8a774b1-usb3-phy # RZ/G2N
> + - renesas,r8a7795-usb3-phy # R-Car H3
> + - renesas,r8a7796-usb3-phy # R-Car M3-W
> + - renesas,r8a77965-usb3-phy # R-Car M3-N
> + - const: renesas,rcar-gen3-usb3-phy
> +
> + reg:
> + # base address and length of the registers block for the PHY.

I think this comment can be removed.

> + maxItems: 1
> +
> + clocks:
> + # A list of phandles and clock-specifier pairs.

Likewise.

"minItems: 2"?

> + maxItems: 3
> +
> + clock-names:
> + # If you want to use the ssc, the clock-frequency of usb_extal
> + # must not be 0.

"minItems: 2"?

> + maxItems: 3
> + items:
> + - const: usb3-if # The funcional clock
> + - const: usb3s_clk # The usb3's external clock
> + - const: usb_extal # The usb2's external clock
> +
> + '#phy-cells':
> + # see phy-bindings.txt in the same directory
> + const: 0
> +
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + renesas,ssc-range:
> + description: |
> + Enable/disable spread spectrum clock (ssc). 0 or the property doesn't
> + exist means disabliing the ssc.

disabling

The actual value will be -<value> ppm.

> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - enum: [ 0, 4003, 4492, 4980 ]
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + usb-phy@e65ee000 {
> + compatible = "renesas,r8a7795-usb3-phy", "renesas,rcar-gen3-usb3-phy";
> + reg = <0 0xe65ee000 0 0x90>;

Examples use the default #{address,size}-cells of <1>, so

reg = <0xe65ee000 0x90>;

> + clocks = <&cpg CPG_MOD 328>, <&usb3s0_clk>, <&usb_extal>;
> + clock-names = "usb3-if", "usb3s_clk", "usb_extal";
> + #phy-cells = <0>;
> + };

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-03-26 09:53    [W:0.101 / U:6.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site