Messages in this thread | | | Subject | Re: [PATCH] ethtool: Report speed and duplex as unknown when device is runtime suspended | From | Florian Fainelli <> | Date | Thu, 26 Mar 2020 19:56:29 -0700 |
| |
On 3/26/2020 7:45 PM, Kai-Heng Feng wrote: > Device like igb gets runtime suspended when there's no link partner. We > can't get correct speed under that state: > $ cat /sys/class/net/enp3s0/speed > 1000 > > In addition to that, an error can also be spotted in dmesg: > [ 385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost > > Since device can only be runtime suspended when there's no link partner, > we can directly report the speed and duplex as unknown. > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: Aaron Brown <aaron.f.brown@intel.com> > Suggested-by: Alexander Duyck <alexander.duyck@gmail.com> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
I would push this to the responsibility of the various drivers instead of making this part of the standard ethtool implementation. -- Florian
| |