lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nvme: Fix NVME_IOCTL_ADMIN_CMD compat address handling.
A couple of comments:

No need for the "." the end of the subject line.

I also think you should just talk of the nvme_user_cmd function,
as that also is used for the NVME_IOCTL_IO_CMD ioctl. Also there now
is a nvme_user_cmd64 variant that needs the same fix, can you also
include that?

> + if (in_compat_syscall()) {
> + /*
> + * On real 32-bit kernels this implementation ignores the
> + * upper bits of address fields so we must replicate that
> + * behaviour in the compat case.

s/real //g please, there are no fake 32-vit kernels :)

\
 
 \ /
  Last update: 2020-03-25 20:12    [W:0.084 / U:7.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site