[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 0/6] Fix errors when try to build kvm selftests on specified output
On 3/25/20 8:01 AM, Xiaoyao Li wrote:
> I attempted to build KVM selftests on a specified dir, unfortunately
> neither "make O=/path/to/mydir TARGETS=kvm" in tools/testing/selftests, nor
> "make OUTPUT=/path/to/mydir" in tools/testing/selftests/kvm work.

Please elaborate on the problems you are seeing. I would like you
to describe in detail the problems you are seeing and how you are
fixing them in this patch series.

The problem you are fixing here is subdir structure not being
supported for relocatable builds and the Makefile not being
able to locate headers files. These are issues, however, these
need to be fixed in the kvm Makefile.

Please look at arm64, android, futex tests as examples.
and main selftests Makefile allow for overrides for make targets.
When a test has sub-dir structure and libraries, it is easier to
handle these in the individual Makefile.

Please fix the problems you are seeing in kvm Makefile.

>I only test the sub TARGET of kvm.
>In theory, it won't break other TARGET of selftests.

When you change which is a common infrastructure, theory
doesn't help. Statements like this make me very reluctant to
accept patches. :)

This is one reason why I asked Paolo to drop these patches.

-- Shuah

 \ /
  Last update: 2020-03-25 17:14    [W:0.088 / U:5.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site