[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c)

On 3/24/2020 9:48 PM, Bjorn Helgaas wrote:
> External email: Use caution opening links or attachments
> On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote:
>> On 3/23/20 9:30 PM, wrote:
>>> The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to
>>> mmotm-readme.txt says
>>> README for mm-of-the-moment:
>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
>>> more than once a week.
>>> You will need quilt to apply these patches to the latest Linus release (5.x
>>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
>> on x86_64:
>> ../drivers/pci/controller/dwc/pcie-tegra194.c: In function ‘tegra_pcie_dw_parse_dt’:
>> ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_phy_get’? [-Werror=implicit-function-declaration]
>> pcie->pex_rst_gpiod = devm_gpiod_get(pcie->dev, "reset", GPIOD_IN);
>> ^~~~~~~~~~~~~~
>> devm_phy_get
> Thanks a lot for the report!
> This was found on mmotm, but I updated my -next branch with Lorenzo's
> latest pci/endpoint branch (current head 775d9e68f470) and reproduced
> this build failure with the .config you attached.
> I dropped that branch from my -next branch for now and pushed it.
I found that one header file inclusion is missing.
The following patch fixes it.
Also, I wanted to know how can I catch this locally? i.e. How can I
generate the config file attached by Randy locally so that I can get the
source ready without these kind of issues?

Bjorn/Lorenzo, would you be able to apply below change in your trees or
do I need to send a patch for this?

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c
index 97d3f3db1020..eeeca18892c6 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -11,6 +11,7 @@
#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/iopoll.h>
#include <linux/kernel.h>

> Bjorn

 \ /
  Last update: 2020-03-25 16:14    [W:0.046 / U:37.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site