lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger
Date
Thanks for the patience Andy,

On Wed, 2020-03-25 at 15:21 +0200, andriy.shevchenko@linux.intel.com
wrote:
> On Wed, Mar 25, 2020 at 03:20:33PM +0200,
> andriy.shevchenko@linux.intel.com wrote:
> > On Wed, Mar 25, 2020 at 01:00:21PM +0000, Vaittinen, Matti wrote:
> > But why?
> >
> > You really uglify the code with ifdeffery, make a dependency to OF
> > (yes, you
> > will have to have of.h include) only because of that silly
> > macro and save 64 bytes of memory footprint.
>
> And on top of that for !OF configuration you prevent your driver to
> be usable.
> (Consider PRP0001 ACPI case, for example)
>

And here I revealed my ignorance what comes to ACPI world :) I didn't
know there is a way to utilize DT compatibles from ACPI.

Another mistake I did was assuming that the of_device_id would reside
in of.h. Thanks for the guidance - I do agree with you. I'll drop both
the ifdef and of_match_ptr().

Br,
Matti
\
 
 \ /
  Last update: 2020-03-25 14:48    [W:0.067 / U:8.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site