lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger
On Wed, Mar 25, 2020 at 03:20:33PM +0200, andriy.shevchenko@linux.intel.com wrote:
> On Wed, Mar 25, 2020 at 01:00:21PM +0000, Vaittinen, Matti wrote:

> But why?
>
> You really uglify the code with ifdeffery, make a dependency to OF (yes, you
> will have to have of.h include) only because of that silly
> macro and save 64 bytes of memory footprint.

And on top of that for !OF configuration you prevent your driver to be usable.
(Consider PRP0001 ACPI case, for example)

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-03-25 14:22    [W:0.056 / U:3.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site