lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v4 0/2] nvmem: use is_bin_visible callback
Date
As suggested I managed to use is_bin_visible for the existing code
and also added few more checks for callbacks before setting
permissions on the file. Which also means that Thunderbolt case
for write-only should be fixed automatically with this patch.

As part of this cleanup it does not make any sense to keep
nvmem-sysfs.c and nvmem.h anymore, so move all the relevant
code to core.c

Changes since v3:
- Split patch2 in to two patches for better review.
- drop first patch to add root_only as its queued

Changes since v2:
- Remove nvmem_sysfs_get_groups()
- remove nvmem-sysfs.c and nvmem.h and move all
relevant code to core.c

Changes since v1:
- Updated permissions setup logic as suggested by Greg
- Added checks for callbacks.

Srinivas Kandagatla (2):
nvmem: core: use is_bin_visible for permissions
nvmem: core: remove nvmem_sysfs_get_groups()

drivers/nvmem/Makefile | 3 -
drivers/nvmem/core.c | 274 +++++++++++++++++++++++++++++++++++-
drivers/nvmem/nvmem-sysfs.c | 269 -----------------------------------
drivers/nvmem/nvmem.h | 65 ---------
4 files changed, 272 insertions(+), 339 deletions(-)
delete mode 100644 drivers/nvmem/nvmem-sysfs.c
delete mode 100644 drivers/nvmem/nvmem.h

--
2.21.0

\
 
 \ /
  Last update: 2020-03-25 14:21    [W:0.028 / U:2.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site